Uploaded image for project: 'C Driver'
  1. C Driver
  2. CDRIVER-2600

Port MONGOC_HAVE_WEAK_SYMBOLS check to CMake

    • Type: Icon: Improvement Improvement
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 1.10.0
    • Affects Version/s: None
    • Component/s: cmake
    • None

      The Autotools build system checks if the compiler supports the (weak) annotation. We use it to prevent Link-Time-Optimization (LTO) in our constant-time mongoc_memcmp(), CDRIVER-815. See WeakSymbols.m4 and mongoc-memcmp.c. I'm not sure this is necessary - why would LTO violate the requirement that different SCRAM keys take the same time to compare?

      Either remove the MONGOC_HAVE_WEAK_SYMBOLS preprocessor symbol, or port the check to CMake.

            Assignee:
            jesse@mongodb.com A. Jesse Jiryu Davis
            Reporter:
            jesse@mongodb.com A. Jesse Jiryu Davis
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: