Uploaded image for project: 'C Driver'
  1. C Driver
  2. CDRIVER-2654

Remove dead code for MONGOC_ENABLE_SASL_GSSAPI

XMLWordPrintableJSON

    • Type: Icon: Improvement Improvement
    • Resolution: Fixed
    • Priority: Icon: Minor - P4 Minor - P4
    • 1.14.0
    • Affects Version/s: 1.7.0
    • Component/s: auth, Build
    • None
    • Fully Compatible

      6932241 added support for building against GSS framework (on macOS) and krb5-gssapi; however, the implementation was never completed and CDRIVER-2170 was resolved as "Won't Fix". This means there is presently dead code in the driver.

      I would suggest removing anything that would possibly link either of those two libraries and the MONGOC_ENABLE_SASL_GSSAPI constant (if it's not a BC break). Additionally, _mongoc_cluster_auth_node_gssapi() can be removed. It presently always returns false, which is contrary to its documentation that a {bson_error_t}} would be set on failure.

            Assignee:
            kevin.albertson@mongodb.com Kevin Albertson
            Reporter:
            jmikola@mongodb.com Jeremy Mikola
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: