-
Type: Investigation
-
Resolution: Done
-
Priority: Major - P3
-
Affects Version/s: None
-
Component/s: None
-
Not Needed
AC
- Audit all usages of 'binary', 'latin1', and 'ascii' as encodings for constructing a node buffer.
- Binary
- Within the constructor remove creating a buffer from the 'binary' encoding (Buffer.from(buffer, 'binary');).
- Open question
do we remove support for string inputs? Or do we want to instead change the encoding to utf8?Answer: no we are going to disallow strings as input. - Add a condition to detect string input and throw a meaningful message. (without this string should still crash due to the constructor only expecting Buffer inputs)
- Remove ISO-8859-1 string format support from Binary class methods and constructor
- Update tests
- depends on
-
NODE-4769 Remove ISO-8859-1 string support from Binary class
- Closed