Uploaded image for project: 'Compass '
  1. Compass
  2. COMPASS-7305

Don't tell electron-installer-common that the compass version is the electron version

    • Type: Icon: Bug Bug
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 1.40.3
    • Affects Version/s: None
    • Component/s: None
    • None
    • Environment:
      OS:
      node.js / npm versions:
      Additional info:
    • Not Needed

      electron-installer-redhat and electron-installer-debian (and probably dmg and the windows one) use electron-installer-common to determine which dependencies electron needs. It can do this for every version of electron. To do that it looks up the version of electron being used from a file called `version` and then does semver matches on it.

      We're writing the compass version number to that file.

      [2023/10/06 09:48:42.754] 2023-10-06T09:48:42.754Z hadron-build:target Writing 11 bytes to /data/mci/8cf423c00db851ddae3081b88d65427c/src/packages/compass/dist/MongoDB Compass Dev-linux-x64/version
      [2023/10/06 09:48:42.756] Fri, 06 Oct 2023 09:48:42 GMT mongodb-js-cli version `0.0.1-dev.0` written to `/data/mci/8cf423c00db851ddae3081b88d65427c/src/packages/compass/dist/MongoDB Compass Dev-linux-x64/version`
      

      Here:
      https://github.com/mongodb-js/compass/blob/cc9160965dfe9d6ca7578fc6a18d9d7903f5ac55/packages/hadron-build/commands/release.js#L193

      So for dev releases we always get the deps required by the very first release of electron and for the current release we get ones matching 1.40.2 and so on:

      $ dpkg -I ./mongodb-compass-dev_0.0.1-dev.0_amd64.deb
       new Debian package, version 2.0.
       size 103785794 bytes: control archive=461 bytes.
           501 bytes,    13 lines      control
       Package: mongodb-compass-dev
       Version: 0.0.1-dev.0
       Section: Databases
       Priority: optional
       Architecture: amd64
       Depends: libgtk2.0-0, libnotify4, libnss3, libxtst6, xdg-utils, libgconf-2-4 | libgconf2-4, libxss1, gvfs-bin, libsecret-1-0
       Recommends: pulseaudio | libasound2
       Suggests: gir1.2-gnomekeyring-1.0, libgnome-keyring0, lsb-release
       Installed-Size: 402879
       Maintainer: MongoDB Inc <compass@mongodb.com>
       Homepage: https://www.mongodb.com/products/compass
       Description: The MongoDB GUI
        The MongoDB GUI
      
      rpm -qpR ./mongodb-compass-dev-0.0.1-dev.0.x86_64.rpm
      warning: ./mongodb-compass-dev-0.0.1-dev.0.x86_64.rpm: Header V3 RSA/SHA256 Signature, key ID f9f5f923: NOKEY
      gtk2
      libnotify
      nss
      libXScrnSaver
      libXtst
      xdg-utils
      GConf2
      libsecret
      rpmlib(FileDigests) <= 4.6.0-1
      rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      rpmlib(CompressedFileNames) <= 3.0.4-1
      rpmlib(PayloadIsXz) <= 5.2-1
      

      We should probably fix this. Some of those deps have been removed from newer linux distros.

            Assignee:
            leroux.bodenstein@mongodb.com Le Roux Bodenstein
            Reporter:
            leroux.bodenstein@mongodb.com Le Roux Bodenstein
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: