Uploaded image for project: 'Compass '
  1. Compass
  2. COMPASS-7712

Review inconsistent behaviours in the connection modal form.

    • Type: Icon: Bug Bug
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 1.42.3
    • Affects Version/s: None
    • Component/s: None
    • Environment:
      OS:
      node.js / npm versions:
      Additional info:
    • Developer Tools
    • 1
    • Not Needed
    • Iteration Xiaosaurus

      PR: https://github.com/mongodb-js/compass/pull/5514#pullrequestreview-1919576584

      Comments (here for easiness):

      > If this value never changes, you don't really need to pass it. Or is it supposed to be derived from errors / warning?

      > This should use spacing, we have 16px there

      Use spacing[3] instead of a fixed value of 16px.

      > Nit: this is not really dynamic in any way and so can be defined staically with css and passed as a class name

      Use a CSS class with the grid-area instead of an inline style in packages/connection-form/src/components/connection-form.tsx

      > There is a bug where I can't remove the last letter of the name after entering it due to this usage of OR operator and how it behaves with falsy values. Is this intended or should this fallback to current state value only in case of the action value being null / undefined?

      It should allow to specify the name as an empty string.

      Also, after talking with Sergey, he mentioned that the the toast that shows when there is a connection error might not be necessary if the modal is still open. As in the attached image.

       

            Assignee:
            kevin.mas@mongodb.com Kevin Mas Ruiz
            Reporter:
            kevin.mas@mongodb.com Kevin Mas Ruiz
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: