Uploaded image for project: 'Compass '
  1. Compass
  2. COMPASS-8225

Remove direct dependency on preferences-model from data-service

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 1.44.0
    • Affects Version/s: None
    • Component/s: None
    • None
    • Developer Tools
    • Not Needed

      Similar to logging, we'd want data-service to stay free of direct dependencies on compass sevices that are dependency injected in other parts of the application otherwise. Right now it seems like data-service is using preferences directly to pull information about user proxy configuration before applying those options during connection creation.

      We'd like to remove this direct coupling by either changing data service to accept preferences through dependency injection similar to logging service, or by some other means, for example by passing these as part of "adjusted" connectionInfo in the connection flow in compass-connections (we already do some connection info modification there before it reaches data-service / devtools-connect, so might as well map preferences to data-service connection info there)

            Assignee:
            anna.henningsen@mongodb.com Anna Henningsen
            Reporter:
            sergey.petushkov@mongodb.com Sergey Petushkov
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: