Uploaded image for project: 'C# Driver'
  1. C# Driver
  2. CSHARP-2736

Improve performance of CollectionElementNameValidator

XMLWordPrintableJSON

    • Type: Icon: Improvement Improvement
    • Resolution: Won't Do
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: 2.9.1
    • Component/s: Performance
    • None
    • Hide

      1. What would you like to communicate to the user about this feature?
      2. Would you like the user to see examples of the syntax and/or executable code and its output?
      3. Which versions of the driver/connector does this apply to?

      Show
      1. What would you like to communicate to the user about this feature? 2. Would you like the user to see examples of the syntax and/or executable code and its output? 3. Which versions of the driver/connector does this apply to?

      The current implementation of IsValidElementName method does the string lookup on the List while checking the exceptions. It is faster to use the Array instead. I also checked the performance of using the HashSet for that case, but it's generally worse for that number of elements.

       

      Here is my benchmark: https://github.com/wojciechcibor/BenchmarkMongoElementNameValidator

       

            Assignee:
            Unassigned Unassigned
            Reporter:
            wojciech.cibor@gmail.com Wojciech Cibor
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: