Uploaded image for project: 'C# Driver'
  1. C# Driver
  2. CSHARP-5474

Move newOutputSerializer parameter to AddStages to the end of the parameter list

    • Type: Icon: Improvement Improvement
    • Resolution: Done
    • Priority: Icon: Unknown Unknown
    • 3.2.0
    • Affects Version/s: 3.1.0
    • Component/s: Linq
    • None
    • None
    • Fully Compatible
    • Dotnet Drivers
    • Not Needed
    • None
    • None
    • None
    • None
    • None
    • None

      Currently the newOutputSerializer parameter is the first parameter to AddStages. Its position before the stages being added makes it "look" like it's the input serializer to the first added stage rather than the output serializer of the last added stage. Placing it at the end of the parameter list after the last added stage makes it look more like the output serializer for that last stage.

      The reason it was placed first was so that the new stages could be a `params` parameter. But we can add overloads for 1-4 new stages without using `params` and C#'s new `[]` syntax for array values makes `params` less useful than before.

      These methods are `internal` so this is not a breaking change to any public API.

            Assignee:
            robert@mongodb.com Robert Stam
            Reporter:
            robert@mongodb.com Robert Stam
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:
              None
              None
              None
              None