From our internal discussions, we believe that putting the calling convention declarations on both the declaration and definition of non-class functions will reduce the risk of errors if end users override compiler flags with a different default calling convention.

As part of the work for this ticket, we should audit the declarations for all of the non-method functions in our API should specify BSONCXX_CALL or MONGOCXX_CALL.