-
Type: Spec Change
-
Resolution: Done
-
Priority: Unknown
-
None
-
Component/s: CRUD
-
Needed
-
Summary
When a cursor was created with comment option set, subsequent getMore command called for this cursor should explicitly send same comment, so that the comment is visible in monitoring events for getMore.
If getMore command is send without a comment, it still inherits the comment from the command that created the cursor. The comment will be visible in profiler, logs and $currentOp for that command. However, the comment will not be visible in monitoring events emitted for getMore. Since the main purpose of the comment is to help with debugging/monitoring/detecting problems, it should be visible in monitoring events.
Therefore, when a driver send a getMore command on a cursor that was created with a comment, the driver must send the same comment as an option of getMore command.
See https://mongodb.slack.com/archives/C0VD105QA/p1643632893344749 for an example.
Motivation
Who is the affected end user?
Any user that wants to use comment for tracing purposes, and who relies on command monitoring for this task.
Is this issue urgent?
No. It might be easier to implement this together with DRIVERS-742, but this is not required.
Is this ticket only for tests?
No.
- causes
-
DRIVERS-2243 Inherited comment causes OperationFailure on MongoDB <4.4.0
- Closed
- related to
-
DRIVERS-742 Add support for the comment field to all helpers
- Closed
- split to
-
PHPLIB-749 Support comment option on command helpers
- Closed
-
CDRIVER-4199 Add support for the comment field to all helpers
- Closed
-
NODE-3984 getMore helper should explicitly send inherited comment
- Closed
-
CSHARP-4046 getMore helper should explicitly send inherited comment
- Closed
-
CXX-2450 getMore helper should explicitly send inherited comment
- Closed
-
GODRIVER-2303 getMore helper should explicitly send inherited comment
- Closed
-
JAVA-4489 getMore helper should explicitly send inherited comment
- Closed
-
MOTOR-890 getMore helper should explicitly send inherited comment
- Closed
-
PYTHON-3119 getMore helper should explicitly send inherited comment
- Closed
-
RUBY-2902 getMore helper should explicitly send inherited comment
- Closed
-
RUST-1179 getMore helper should explicitly send inherited comment
- Closed