-
Type: Spec Change
-
Resolution: Done
-
Priority: Major - P3
-
None
-
Component/s: Collection Management
-
Needed
-
Summary
Downstream changes for DRIVERS-1915 mentioned that the create and collMod commands now accept a changeStreamPreAndPostImages document option, which is used to enable pre- and post-images. The commit for that issue added unified change stream spec tests with runCommand operations that execute collMod to enable changeStreamPreAndPostImages on the collection under test (originally created by initialData), but did not add any spec tests for createCollection or collMod helpers that may exist in drivers.
benji.rewis@mongodb.com pointed out that we do have a directory for collection management tests (despite not currently having a collection management spec). We should add unified tests for the changeStreamPreAndPostImages option there. Drivers without helpers can skip them as needed.
Existing spec tests reference a createCollection database operation. These would be the first tests for a collMod helper, so I'll propose we name that database operation modifyCollection unless anyone objects.
Additionally, the server team intentionally implemented changeStreamPreAndPostImages as a document (e.g. {enabled: <boolean>}), so I propose drivers do the same instead of simplifying it as a boolean type and possibly locking themselves into an API limitation down the line.
Motivation
Is this issue urgent?
No, but it should be done alongside language tickets for DRIVERS-1915.
Is this ticket required by a downstream team?
No.
Is this ticket only for tests?
Yes.
- is related to
-
DRIVERS-1915 Change streams support for user-facing PIT pre- and post-images
- Closed
- split to
-
JAVA-4592 Support change stream pre- and post- images options
- Closed
-
GODRIVER-2396 Add createCollection and collMod spec tests for changeStreamPreAndPostImages option
- Closed
-
PHPLIB-856 Add createCollection and collMod spec tests for changeStreamPreAndPostImages option
- Closed
-
CDRIVER-4368 Add createCollection and collMod spec tests for changeStreamPreAndPostImages option
- Closed
-
CSHARP-4152 Add createCollection and collMod spec tests for changeStreamPreAndPostImages option
- Closed
-
CXX-2499 Add createCollection and collMod spec tests for changeStreamPreAndPostImages option
- Closed
-
MOTOR-948 Add createCollection and collMod spec tests for changeStreamPreAndPostImages option
- Closed
-
NODE-4210 Add createCollection and collMod spec tests for changeStreamPreAndPostImages option
- Closed
-
PYTHON-3239 Add createCollection and collMod spec tests for changeStreamPreAndPostImages option
- Closed
-
RUBY-2971 Add createCollection and collMod spec tests for changeStreamPreAndPostImages option
- Closed
-
RUST-1295 Add createCollection and collMod spec tests for changeStreamPreAndPostImages option
- Closed