Uploaded image for project: 'Drivers'
  1. Drivers
  2. DRIVERS-2799

Test-level runOnRequirements in retryable writes tests should not be more permissive than top-level runOnRequirements

XMLWordPrintableJSON

    • Type: Icon: Task Task
    • Resolution: Unresolved
    • Priority: Icon: Minor - P4 Minor - P4
    • None
    • Component/s: Retryability
    • None
    • Needed
    • Hide

      Summary of necessary driver changes

      • No driver changes needed beyond syncing spec tests 

      Commits for syncing spec/prose tests

      • Sync unified spec tests for retryable-writes and unified-test-format/valid-pass with 4c73bb1
      Show
      Summary of necessary driver changes No driver changes needed beyond syncing spec tests  Commits for syncing spec/prose tests Sync unified spec tests for retryable-writes and unified-test-format/valid-pass with 4c73bb1
    • $i18n.getText("admin.common.words.hide")
      Key Status/Resolution FixVersion
      CDRIVER-4798 Fixed 1.26.0
      CXX-2798 Backlog
      CSHARP-4887 Backlog
      GODRIVER-3073 Backlog 2.1.0
      JAVA-5272 Done
      NODE-5797 Fixed 6.4.0
      MOTOR-1226 Duplicate
      PYTHON-4110 Fixed 4.7
      PHPLIB-1326 Fixed 1.18.0
      RUBY-3361 Fixed 2.20.0
      RUST-1811 Backlog
      $i18n.getText("admin.common.words.show")
      #scriptField, #scriptField *{ border: 1px solid black; } #scriptField{ border-collapse: collapse; } #scriptField td { text-align: center; /* Center-align text in table cells */ } #scriptField td.key { text-align: left; /* Left-align text in the Key column */ } #scriptField a { text-decoration: none; /* Remove underlines from links */ border: none; /* Remove border from links */ } /* Add green background color to cells with FixVersion */ #scriptField td.hasFixVersion { background-color: #00FF00; /* Green color code */ } /* Center-align the first row headers */ #scriptField th { text-align: center; } Key Status/Resolution FixVersion CDRIVER-4798 Fixed 1.26.0 CXX-2798 Backlog CSHARP-4887 Backlog GODRIVER-3073 Backlog 2.1.0 JAVA-5272 Done NODE-5797 Fixed 6.4.0 MOTOR-1226 Duplicate PYTHON-4110 Fixed 4.7 PHPLIB-1326 Fixed 1.18.0 RUBY-3361 Fixed 2.20.0 RUST-1811 Backlog

      Summary

      The unified spec tests introduced in ab48c57 for DRIVERS-1385 incorrectly specify top-level runOnRequirements that are more restrictive than the test-level runOnRequirements.

      Those tests may have been copied from the original poc-retryable-writes.yml tests introduced in e4808b8 for DRIVERS-709, which have the same issue.

      This is contrary to the advice in the Unified Test Format spec:

      [Test-level] requirements SHOULD be more restrictive than those specified in the top-level runOnRequirements (if any) and SHOULD NOT be more permissive. This is advised because both sets of requirements MUST be satisified in order for a test to be executed and more permissive requirements at the test-level could be taken out of context on their own.

      As currently written, the spec tests will never run on sharded clusters and load balancers because the top-level runOnRequirements require a replica set.

      Motivation

      Is this issue urgent?

      No.

      Is this ticket required by a downstream team?

      No.

      Is this ticket only for tests?

      Yes.

            Assignee:
            jmikola@mongodb.com Jeremy Mikola
            Reporter:
            jmikola@mongodb.com Jeremy Mikola
            Andreas Braun Andreas Braun
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: