Uploaded image for project: 'Drivers'
  1. Drivers
  2. DRIVERS-3142

Test flexible numeric comparisons with $$lte

XMLWordPrintableJSON

    • Needed - No Spec Changes
    • Hide

      Summary of necessary driver changes

      • Modifies $$lte operator test to also use floating point and Int64 types

      Commits for syncing spec/prose tests

      Show
      Summary of necessary driver changes Modifies $$lte operator test to also use floating point and Int64 types Commits for syncing spec/prose tests Sync unified test format "valid-pass" tests with mongodb/specifications@cef6623
    • $i18n.getText("admin.common.words.hide")
      Key Status/Resolution FixVersion
      CDRIVER-5940 Backlog
      CXX-3254 Backlog
      CSHARP-5534 Done 3.4.0
      GODRIVER-3518 Backlog
      JAVA-5820 Ready for Work
      NODE-6872 Backlog
      MOTOR-1444 Duplicate
      PYTHON-5230 Backlog
      PHPLIB-1650 Fixed 2.0.0
      RUBY-3636 Backlog
      RUST-2186 Fixed 3.3.0
      $i18n.getText("admin.common.words.show")
      #scriptField, #scriptField *{ border: 1px solid black; } #scriptField{ border-collapse: collapse; } #scriptField td { text-align: center; /* Center-align text in table cells */ } #scriptField td.key { text-align: left; /* Left-align text in the Key column */ } #scriptField a { text-decoration: none; /* Remove underlines from links */ border: none; /* Remove border from links */ } /* Add green background color to cells with FixVersion */ #scriptField td.hasFixVersion { background-color: #00FF00; /* Green color code */ } #scriptField td.willNotDo { background-color: #FF0000; /* Red color code */ } /* Center-align the first row headers */ #scriptField th { text-align: center; } Key Status/Resolution FixVersion CDRIVER-5940 Backlog CXX-3254 Backlog CSHARP-5534 Done 3.4.0 GODRIVER-3518 Backlog JAVA-5820 Ready for Work NODE-6872 Backlog MOTOR-1444 Duplicate PYTHON-5230 Backlog PHPLIB-1650 Fixed 2.0.0 RUBY-3636 Backlog RUST-2186 Fixed 3.3.0

      Summary

      The operator-lte.yml test introduced in mongodb/specifications@a8a7d01 does not test flexible numeric comparisons. Adding a test for this exposed an outstanding bug in PHPLIB's test runner (discovered while implementing PHPLIB-1648), so it may be beneficial to other drivers.

      Motivation

      How likely is it that this problem or use case will occur?

      Unlikely, as most tests using $lte utilize integers to compare timeoutMS options w with maxTimeMS values in outgoing commands.

      If the problem does occur, what are the consequences and how severe are they?

      If the comparison fails to compare different numeric types, a test would likely produce a false-negative result. This is likely less serious than a false-positive, which might go unnoticed.

      Is this issue urgent?

      No.

      Is this ticket required by a downstream team?

      No.

      Is this ticket only for tests?

      Yes.

            Assignee:
            jmikola@mongodb.com Jeremy Mikola
            Reporter:
            jmikola@mongodb.com Jeremy Mikola
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: