Uploaded image for project: 'Java Driver'
  1. Java Driver
  2. JAVA-3897

Wrong type for ClusterSettings.Builder#connectTimeOut and readTimeout parameter

XMLWordPrintableJSON

    • Type: Icon: Improvement Improvement
    • Resolution: Done
    • Priority: Icon: Major - P3 Major - P3
    • 5.0.0
    • Affects Version/s: 4.1.1
    • Component/s: Builders
    • None
    • Major Change
    • Needed
    • Hide

      Let's mention in What's new the following API changes that break binary compatibility (the existing compiled code that call these methods has to be recompiled; no source code changes are needed): `com.mongodb.connection.SocketSettings.Builder.connectTimeout`/`readTimeout` now have the first parameter of the `long` type instead of `int`.

      Show
      Let's mention in What's new the following API changes that break binary compatibility (the existing compiled code that call these methods has to be recompiled; no source code changes are needed): `com.mongodb.connection.SocketSettings.Builder.connectTimeout`/`readTimeout` now have the first parameter of the `long` type instead of `int`.

      I think that timeouts parameters of methods on SocketSettings.Builder.Builder should be long,, not int, as it happens on ConnectionPoolSettings.Builder or Clustersettings.Builder

       

      For example, SocketSettings.Builder#connectTimeout(int, java.util.concurrent.TimeUnit) and SocketSettings.Builder#readTimeout(int, java.util.concurrent.TimeUnit) sulf by SocketSettings.Builder#connectTimeout(long, java.util.concurrent.TimeUnit) and SocketSettings.Builder#readTimeout(long, java.util.concurrent.TimeUnit)

            Assignee:
            valentin.kovalenko@mongodb.com Valentin Kavalenka
            Reporter:
            oscar.burgos-martin@capgemini.com Óscar Burgos
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: