Uploaded image for project: 'Libmongocrypt'
  1. Libmongocrypt
  2. MONGOCRYPT-555

_finalize is missing call to bson_destroy in an error case

    • Type: Icon: Bug Bug
    • Resolution: Done
    • Priority: Icon: Unknown Unknown
    • 1.8.0
    • Affects Version/s: None
    • Component/s: None
    • None
    • Not Needed

      In _finalize in mongocrypt-ctx-encrypt.c, the error case starting on line 2011 (in commit 2ec9c3) appears to be missing bson_destroy (&converted). This is because in the case where ectx->explicit is false on line 1985 and the bson_t converted is initialized on line 1996, if the call to _mongocrypt_buffer_to_bson fails on line 2009, _finalize returns without having destroyed the converted instance.

            Assignee:
            kyle.kloberdanz@mongodb.com Kyle Kloberdanz (Inactive)
            Reporter:
            zachary.espiritu@mongodb.com Zachary Espiritu
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: