Uploaded image for project: 'MongoDB Shell'
  1. MongoDB Shell
  2. MONGOSH-427

Use node driver types in service-provider-core directly

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 0.7.7
    • Affects Version/s: None
    • Component/s: Services Providers
    • None
    • 5
    • Not Needed
    • Iteration Rambutan

      We currently define a bunch of typescript types that are the same as the driver (cursor, various options, connect info, etc.) that the driver now defines in ts. investigate if we can replace our own types with direct use of the driver types using "import type" plus the library for manipulating types (https://www.typescriptlang.org/docs/handbook/utility-types.html)

       

      If we can get rid of the double definitions, we will save a lot of code!

       

      Open questions: make sure it's browser safe to import the driver types, make sure there's a released version of the driver with these types that we can use, make sure we allow ourselves the ability to extend those types in sp-core in the future when we have non-node-driver based service providers.

       

            Assignee:
            anna.herlihy@mongodb.com Anna Herlihy (Inactive)
            Reporter:
            anna.herlihy@mongodb.com Anna Herlihy (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: