Uploaded image for project: 'Motor'
  1. Motor
  2. MOTOR-202

aiohttp 3 compatibility

    • Type: Icon: Improvement Improvement
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 2.0
    • Affects Version/s: None
    • Component/s: aiohttp
    • None

      When aiohttp released 3.0.0 it broke Motor's tests on RHEL 6.2:

       [2018/02/21 16:38:43.350] Traceback (most recent call last):
       [2018/02/21 16:38:43.350]   File "/data/mci/5699cc243242ac2ac81ef534d934bd0d/src/.tox/asyncio-py36/lib/python3.6/site-packages/aiohttp/web_protocol.py", line 376, in start
       [2018/02/21 16:38:43.350]     resp = await self._request_handler(request)
       [2018/02/21 16:38:43.350]   File "/data/mci/5699cc243242ac2ac81ef534d934bd0d/src/.tox/asyncio-py36/lib/python3.6/site-packages/aiohttp/web_app.py", line 310, in _handle
       [2018/02/21 16:38:43.350]     resp = await handler(request)
       [2018/02/21 16:38:43.350]   File "/data/mci/5699cc243242ac2ac81ef534d934bd0d/src/.tox/asyncio-py36/lib/python3.6/site-packages/aiohttp/web_urldispatcher.py", line 136, in handler_wrapper
       [2018/02/21 16:38:43.350]     result = await result
       [2018/02/21 16:38:43.350]   File "/data/mci/5699cc243242ac2ac81ef534d934bd0d/src/motor/aiohttp/__init__.py", line 222, in __call__
       [2018/02/21 16:38:43.350]     resp.set_tcp_cork(True)
       [2018/02/21 16:38:43.350] AttributeError: 'StreamResponse' object has no attribute 'set_tcp_cork'
      

      Breaking change: https://github.com/aio-libs/aiohttp/pull/2612/files

            Assignee:
            jesse@mongodb.com A. Jesse Jiryu Davis
            Reporter:
            jesse@mongodb.com A. Jesse Jiryu Davis
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: