Uploaded image for project: 'Node.js Driver'
  1. Node.js Driver
  2. NODE-2492

Rely on Buffer guaranteed presence to improve ObjectId performance

XMLWordPrintableJSON

    • Type: Icon: Improvement Improvement
    • Resolution: Gone away
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: BSON, Performance
    • Not Needed
    • Hide

      1. What would you like to communicate to the user about this feature?
      2. Would you like the user to see examples of the syntax and/or executable code and its output?
      3. Which versions of the driver/connector does this apply to?

      Show
      1. What would you like to communicate to the user about this feature? 2. Would you like the user to see examples of the syntax and/or executable code and its output? 3. Which versions of the driver/connector does this apply to?

      Since we can now rely on Buffer being present we can get rid of the custom logic to translate hex strings. Simplify the equals method by no longer needing a call to isValid (a noticeably slow function). Opportunity to coerce the type of id to always be of Buffer to further simplify equals.

            Assignee:
            Unassigned Unassigned
            Reporter:
            neal.beeken@mongodb.com Neal Beeken
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: