Uploaded image for project: 'Node.js Driver'
  1. Node.js Driver
  2. NODE-3494

Implement support and integrate tests for observeSensitiveCommands

XMLWordPrintableJSON

    • 3
    • 0
    • Hide

      DRIVERS-1868:
      Sync valid-pass tests for the unified test format to mongodb/specifications@6847048. Also note that some additional clarifications were added to the spec itself concerning implementation of observeSensitiveEvents (originally introduced in DRIVERS-1653); however, the behavior of the syntax has not been changed.

      Show
      DRIVERS-1868 : Sync valid-pass tests for the unified test format to mongodb/specifications@6847048 . Also note that some additional clarifications were added to the spec itself concerning implementation of observeSensitiveEvents (originally introduced in DRIVERS-1653); however, the behavior of the syntax has not been changed.
    • Not Needed
    • Not Needed
    • Hide

      1. What would you like to communicate to the user about this feature?
      2. Would you like the user to see examples of the syntax and/or executable code and its output?
      3. Which versions of the driver/connector does this apply to?

      Show
      1. What would you like to communicate to the user about this feature? 2. Would you like the user to see examples of the syntax and/or executable code and its output? 3. Which versions of the driver/connector does this apply to?

      Driver Changes: Sync valid-pass tests for the unified test format to mongodb/specifications@6847048. Also note that some additional clarifications were added to the spec itself concerning implementation of observeSensitiveEvents (originally introduced in DRIVERS-1653); however, the behavior of the syntax has not been changed.

      AC

      • Sync the latest observeSensitiveCommands spec tests (not the commit in the downstream changes)
      • Run the tests and verify that we've implemented observeSensitiveEvents correctly
      • If tests still fail, identify if it is a runner or driver issue.
      • Assuming it is not a driver issue, make the test runner changes needed to filter sensitive commands
      • If there is an issue with the driver, file a follow-up, and block this ticket

      Summary

      DRIVERS-1653 introduced observeSensitiveCommands to the unified test runner (schema version 1.5); however, it did not include integration tests for the new syntax. The test cases pertaining to sensitive command redaction are not sufficient to verify that drivers have implemented the new syntax completely. This issue will add integration tests to do so.

      Motivation

      Who is the affected end user?

      Drivers.

      How does this affect the end user?

      Does not affect the end user.

      How likely is it that this problem or use case will occur?

      It's quite possible that observeSensitiveCommands can be implemented incorrectly if drivers are only using the redaction tests in DRIVERS-1653 to verify their implementations.

      If the problem does occur, what are the consequences and how severe are they?

      The risk is an incorrect test runner implementation.

      Is this issue urgent?

      This should be done alongside DRIVERS-1653, but individual drivers can make that call.

      Is this ticket required by a downstream team?

      No.

      Is this ticket only for tests?

      Only tests.

            Assignee:
            alena.khineika@mongodb.com Alena Khineika
            Reporter:
            backlog-server-pm Backlog - Core Eng Program Management Team
            Aditi Khare
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: