Uploaded image for project: 'Node.js Driver'
  1. Node.js Driver
  2. NODE-3790

Remove "ismaster" from test files

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Unknown Unknown
    • 4.3.0
    • Affects Version/s: None
    • Component/s: None
    • None
    • Not Needed

      Use Case

      As a developer
      I want the tests to not include the offensive "ismaster" term
      So that I don't become offended or distracted while working with the Node driver code

      User Impact

      Unknown

      Dependencies

      None

      Unknowns

      1. Should I create a global constant or create the constant in each test file?

      Acceptance Criteria

      • All instances of ismaster in the test files are replaced with a constant named LEGACY_HELLO_COMMAND

      Implementation Requirements

      • Create const LEGACY_HELLO_COMMAND="isMaster". Replace instances of isMaster with references to that constant. For example,
        `if (doc.ismaster || doc.hello)`becomes 
        `if (doc[LEGACY_HELLO_COMMAND] || doc.hello) {`

      Testing Requirements

      • None

      Documentation Requirements

      • None

      Follow Up Requirements

            Assignee:
            durran.jordan@mongodb.com Durran Jordan
            Reporter:
            lauren.schaefer@mongodb.com Lauren Schaefer
            Durran Jordan
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: