Uploaded image for project: 'Node.js Driver'
  1. Node.js Driver
  2. NODE-3792

Update references to ismaster throughout the codebase

XMLWordPrintableJSON

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Unknown Unknown
    • 4.3.1
    • Affects Version/s: None
    • Component/s: None
    • None
    • Not Needed

      Use Case

      As a developer
      I want references to ismaster to be removed
      So that I don't become offended or distracted while working with the Node driver code

      From the Scope doc:

      Where the deprecated terminology is required, use a constant or variable to abstract away and limit usage of the deprecated term.

      User Impact

      Unknown

      Dependencies

      • None

      Unknowns

      1. Should documents named `ismaster` be renamed to `hello`? See src/cmap/auth/mongo_credentials.ts for an example.
      2. Should lastIsMaster() in topology.ts be renamed to lastPrimary()?

      Acceptance Criteria

      • All references to ismaster are renamed (e.g. hello) or replaced with a constant(e.g. const LEGACY_HELLO_COMMAND="isMaster")
      • Current code ismaster.ismaster = ismaster.isWritablePrimary. Need to flip this
      • Any associated documentation that is automatically generated from code comments is also updated to reflect the non-offensive names

      Implementation Requirements

      • None

      Testing Requirements

      • None

      Documentation Requirements

      • None

      Follow Up Requirements

            Assignee:
            neal.beeken@mongodb.com Neal Beeken
            Reporter:
            lauren.schaefer@mongodb.com Lauren Schaefer
            Neal Beeken
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: