Uploaded image for project: 'Node.js Driver'
  1. Node.js Driver
  2. NODE-4034

Spec Compliance: BulkWrite result are not the same as spec expectations

XMLWordPrintableJSON

    • Type: Icon: Improvement Improvement
    • Resolution: Fixed
    • Priority: Icon: Unknown Unknown
    • 5.0.0
    • Affects Version/s: None
    • Component/s: None
    • 2
    • Not Needed
    • Not Needed

      In the retryable spec tests we need to test partial deep equality with the expected result, in addition to checking first for a "value" property that holds the real operation result.

      We should investigate what changes are needed to make these CRUD operations exactly deep equal to the spec expectations.

      Test runner in:
      retryable-writes/retryable_writes.spec.test.ts

       

      AC:

      • Make the sure the following are accessible on the BulkWriteResult class:
        • deletedCount
        • insertedCount
        • insertedIds
        • matchedCount
        • modifiedCount
        • upsertedCount
        • upsertedIds
      • Make the result property private and non-enumerable. (NODE-4393)
      • enable the deep equality checking in the test runner
      • Mark BulkResult as internal in the API.
      • Remove BulkWriteResult.toJSON()
      • Document changes in the migration guide
      •  

            Assignee:
            durran.jordan@mongodb.com Durran Jordan
            Reporter:
            neal.beeken@mongodb.com Neal Beeken
            Bailey Pearson
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: