Uploaded image for project: 'Node.js Driver'
  1. Node.js Driver
  2. NODE-4961

commitTransaction and abortTransaction return command result

XMLWordPrintableJSON

    • 2
    • Needed
    • Needed
    • Hide

      1. What would you like to communicate to the user about this feature?
      2. Would you like the user to see examples of the syntax and/or executable code and its output?
      3. Which versions of the driver/connector does this apply to?

      Show
      1. What would you like to communicate to the user about this feature? 2. Would you like the user to see examples of the syntax and/or executable code and its output? 3. Which versions of the driver/connector does this apply to?

      Use Case

      As a node driver engineer
      I want to align with the driver's spec

      The transaction spec has function prototypes for abortTransaction and commitTransaction which indicate they should return void. Currently, the driver returns the raw command result for each respective operation

      User Impact

      • Breaking change: The return type of the function will be changed to void

      Dependencies

      • None

      Unknowns

      • None

      Acceptance Criteria

      Implementation Requirements

      • Fix the promise chain to not return a value

      Testing Requirements

      • Regression test

      Documentation Requirements

      • Release notes mention the breaking change

      Follow Up Requirements

      • None

            Assignee:
            neal.beeken@mongodb.com Neal Beeken
            Reporter:
            neal.beeken@mongodb.com Neal Beeken
            Bailey Pearson
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: