Uploaded image for project: 'Node.js Driver'
  1. Node.js Driver
  2. NODE-5592

Fix return type of withTransaction

XMLWordPrintableJSON

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 6.0.0
    • Affects Version/s: None
    • Component/s: None
    • 0
    • Not Needed
    • Not Needed
    • Hide

      1. What would you like to communicate to the user about this feature?
      2. Would you like the user to see examples of the syntax and/or executable code and its output?
      3. Which versions of the driver/connector does this apply to?

      Show
      1. What would you like to communicate to the user about this feature? 2. Would you like the user to see examples of the syntax and/or executable code and its output? 3. Which versions of the driver/connector does this apply to?

      Use Case

      As a... Driver engineer
      I want... to fix the return type of withTransaction
      So that... linting and code hinting works correctly

      User Impact

      • N/A

      Dependencies

      • N/A

      Unknowns

      • N/A

      Acceptance Criteria

      Implementation Requirements

      • Change return type from Promise<Document | undefined> to Promise<T|undefined>

      Testing Requirements

      • Add type test for withTransaction that ensures that its generics work correctly

      Documentation Requirements

      • N/A

      Follow Up Requirements

      • N/A

            Assignee:
            warren.james@mongodb.com Warren James
            Reporter:
            warren.james@mongodb.com Warren James
            Neal Beeken
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: