Uploaded image for project: 'Node.js Driver'
  1. Node.js Driver
  2. NODE-5818

Server Selection logging changes cause performance regression

    • Not Needed
    • Hide

      1. What would you like to communicate to the user about this feature?
      2. Would you like the user to see examples of the syntax and/or executable code and its output?
      3. Which versions of the driver/connector does this apply to?

      Show
      1. What would you like to communicate to the user about this feature? 2. Would you like the user to see examples of the syntax and/or executable code and its output? 3. Which versions of the driver/connector does this apply to?

      Changes introduced on main server selection path to accommodate negatively affect performance in a number of performance tests. Links to evergreen notifications listed in dev comment

      Acceptance Criteria 

      • Inspect all server selection events to see if any costly operations (duplicate function calls, deep clones etc)
      • Feature flag topology.ts every time it creates a server selection event, so that the event object is only created when logging is turned on for that component and severity level

      Testing Requirements

      • Rerun Affected Tests, and record new % change
        • findOne - 6% throughput reduction
        • runCommand - 9% throughput reduction
        • smallDocInsertOne - 6.5% throughput reduction
      • Ensure that when mongologger is turned off for server selection, we do not create server selection events

            Assignee:
            aditi.khare@mongodb.com Aditi Khare
            Reporter:
            warren.james@mongodb.com Warren James
            Alena Khineika, Durran Jordan
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: