Uploaded image for project: 'Node.js Driver'
  1. Node.js Driver
  2. NODE-6045

Ensure that the first server heartbeat does not report that it is awaited

    • Type: Icon: Task Task
    • Resolution: Unresolved
    • Priority: Icon: Minor - P4 Minor - P4
    • None
    • Affects Version/s: None
    • Component/s: SDAM, Testing
    • Hide

      1. What would you like to communicate to the user about this feature?
      2. Would you like the user to see examples of the syntax and/or executable code and its output?
      3. Which versions of the driver/connector does this apply to?

      Show
      1. What would you like to communicate to the user about this feature? 2. Would you like the user to see examples of the syntax and/or executable code and its output? 3. Which versions of the driver/connector does this apply to?

      While working on DRIVERS-2711 POC (NODE-5723), on fixing a bug in the unified test runner, it was discovered that the Node driver awaits(or reports that it awaits) the first server heartbeat regardless of the configured value of the serverMonitoringMode option, which leads to failures on the following spec tests:

      Note that the failure is only on the assertion for the awaited field of the first ServerHeartbeatSucceededEvent.

      Use Case

      As a... driver engineer
      I want... to change our heartbeat succeeded emit logic to not await the first heartbeat
      So that... our SDAM behaviour is spec-compliant

      User Impact

      • Minor, likely not noticed by users

      Dependencies

      • None

      Unknowns

      • Is the heartbeat actually awaited or does the driver only report that it is awaited?

      Acceptance Criteria

      Implementation Requirements

      • Ensure that the first heartbeat emitted when connecting to a server is never await regardless of the value of serverMonitoringMode when connecting to servers that have streamable heartbeats (mongo versions >= 4.4)

      Testing Requirements

      Documentation Requirements

      • None

      Follow Up Requirements

      • None

            Assignee:
            Unassigned Unassigned
            Reporter:
            warren.james@mongodb.com Warren James
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: