Uploaded image for project: 'PHP Driver: Extension'
  1. PHP Driver: Extension
  2. PHPC-1962

Create macros for assigning zvals to HashTables

XMLWordPrintableJSON

    • Type: Icon: Task Task
    • Resolution: Unresolved
    • Priority: Icon: Minor - P4 Minor - P4
    • None
    • Affects Version/s: None
    • Component/s: None

      In the code review for PHPC-1849, andreas.braun suggested creating macros for the common case of declaring/setting a zval and assigning to to a HashTable. This is frequently done in get_properties_hash helpers for various classes. Unlike the array macros, no such macros exist for HashTable.

      See:

       * https://github.com/mongodb/mongo-php-driver/pull/1246#discussion_r699193650
       * https://github.com/mongodb/mongo-php-driver/pull/1246#discussion_r699197023

            Assignee:
            Unassigned Unassigned
            Reporter:
            jmikola@mongodb.com Jeremy Mikola
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: