Uploaded image for project: 'PHP Driver: Extension'
  1. PHP Driver: Extension
  2. PHPC-345

bson_to_zval() should throw exceptions instead of warnings

    • Type: Icon: Improvement Improvement
    • Resolution: Done
    • Priority: Icon: Major - P3 Major - P3
    • 1.0.0-alpha1
    • Affects Version/s: 0.6.3
    • Component/s: None
    • None

      We currently trigger warnings for the following:

      • "Could not read document from reader"
      • "Could not initialize BSON iterator"
      • "Reading document did not exhaust input buffer"

      Aside from src/contrib/php-ssl.c, these are the only errors/warnings emitted by the extension. We should change these to exceptions.

      Additionally, this would resolve some test output differences with HHVM (see: PR #66).

            Assignee:
            jmikola@mongodb.com Jeremy Mikola
            Reporter:
            jmikola@mongodb.com Jeremy Mikola
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: