Uploaded image for project: 'PHP Driver: Extension'
  1. PHP Driver: Extension
  2. PHPC-758

Disable Decimal128 for bundled libbson and libmongoc 1.4.0

    • Type: Icon: Task Task
    • Resolution: Done
    • Priority: Icon: Major - P3 Major - P3
    • 1.2.0-alpha1, 1.2.0
    • Affects Version/s: None
    • Component/s: None
    • None

      CDRIVER-1337 introduced a BSON_EXPERIMENTAL_FEATURES and MONGOC_EXPERIMENTAL_FEATURES flags for experimental 3.4 features in libbson and libmongoc 1.4.0, respectively.

      Presently, our Decimal128 implementation is the only code that utilizes these features. For the upgrade to 1.4.0, we should wrap the Decimal128-specific code in an #ifdef BSON_EXPERIMENTAL_FEATURES block.

      We can disable BSON_EXPERIMENTAL_FEATURES for the bundled libbson and libmongoc build and defer to the system library otherwise. In that case, the class will be available if the system library was compiled to support experimental features.

            Assignee:
            jmikola@mongodb.com Jeremy Mikola
            Reporter:
            jmikola@mongodb.com Jeremy Mikola
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: