Uploaded image for project: 'PHP Driver: Library'
  1. PHP Driver: Library
  2. PHPLIB-1106

Upgrade doctrine/coding-standard to 11.1.0

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Unknown Unknown
    • 1.16.0
    • Affects Version/s: None
    • Component/s: None
    • None

      I encountered the following phpcs error when testing PHPLIB-913:

      FILE: src/Operation/CreateEncryptedCollection.php
      ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
      FOUND 1 ERROR AND 6 WARNINGS AFFECTING 7 LINES
      ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
         1 | ERROR   | An error occurred during processing; checking has been aborted. The error message was: Undefined property: PHPStan\PhpDocParser\Ast\Type\ObjectShapeNode::$name in
           |         | /phplib/vendor/slevomat/coding-standard/SlevomatCodingStandard/Helpers/AnnotationTypeHelper.php on line 357 (Internal.Exception)
      

      Object shapes were recently introduced in phpstan/phpdoc-parser 1.18.0 (phpstan/phpdoc-parser@882eabc), which necessitates upgrading to slevomat/coding-standard 8.10.0 (slevomat/coding-standard@b3c64a3) to avoid the error above.

      We indirectly require slevomat/coding-standard through doctrine/coding-standard, so this effectively means we'll need to upgrade our doctrine/coding-standard dependency. We currently use ^9.0 and the current version is 11.1.0.

            Assignee:
            jmikola@mongodb.com Jeremy Mikola
            Reporter:
            jmikola@mongodb.com Jeremy Mikola
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: