Uploaded image for project: 'PHP Driver: Library'
  1. PHP Driver: Library
  2. PHPLIB-1162

Remove unused $server argument in Explainable::getCommandDocument

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Minor - P4 Minor - P4
    • 1.16.0
    • Affects Version/s: None
    • Component/s: None
    • None

      The argument Server $server of Explainable::getCommandDocument is never used. I don't think this is ever necessary as the private methods createCommand never get the Server instance.

      The interface is internal, so we can change it without introducing a breaking change.

      This change will simplify unit-testing implementation of this methods PHPLIB-1144 as we don't have to instantiate or mock the final class Server.

            Assignee:
            jerome.tamarelle@mongodb.com Jérôme Tamarelle
            Reporter:
            jerome.tamarelle@mongodb.com Jérôme Tamarelle
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: