Uploaded image for project: 'Realm Core'
  1. Realm Core
  2. RCORE-1459

Sync client should not ignore "non-sensical" timeouts

    • Type: Icon: Improvement Improvement
    • Resolution: Unresolved
    • Priority: Icon: Minor - P4 Minor - P4
    • None
    • Affects Version/s: None
    • Component/s: Sync

      The sync client will ignore certain config options if they don't have values it deems "sensible". While this kind of makes sense to me, silently ignoring these values does not seem right. Ideally, we should accept whatever the SDK supplies and emit warning messages if the timeouts are too short. The reasoning here is that there are certain error conditions, which we can write integration tests for if we reduce the connect timeout significantly, but as it stands today, we can't.

      Here's the code I think we should change to log warnings rather than ignore certain values:

      https://github.com/realm/realm-core/blob/9d6ef5e329b4f298d9b5b4c09088cad08473c473/src/realm/object-store/sync/impl/sync_client.hpp#L57-L67

            Assignee:
            Unassigned Unassigned
            Reporter:
            nikola.irinchev@mongodb.com Nikola Irinchev
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: