Uploaded image for project: 'Ruby Driver'
  1. Ruby Driver
  2. RUBY-1168

Correct BSON corpus Decimal128 test failures

    • Type: Icon: Improvement Improvement
    • Resolution: Done
    • Priority: Icon: Minor - P4 Minor - P4
    • bson-5.0.0
    • Affects Version/s: None
    • Component/s: BSON
    • None

      Currently omitted tests:

      diff --git a/spec/spec_tests/data/corpus/decimal128-4.json b/spec/spec_tests/data/corpus/decimal128-4.json
      index ccad69a..0957019 100644
      --- a/spec/spec_tests/data/corpus/decimal128-4.json
      +++ b/spec/spec_tests/data/corpus/decimal128-4.json
      @@ -112,6 +112,54 @@
              {
                 "description": "[basx563] Near-specials (Conversion_syntax)",
                 "string": "NaNs"
      +       },
      +       {
      +          "description": "[dqbas939] overflow results at different rounding modes (Overflow & Inexact & Rounded)",
      +          "string": "-7e10000"
      +       },
      +       {
      +          "description": "[dqbsr534] negatives (Rounded & Inexact)",
      +          "string": "-1.11111111111111111111111111111234650"
      +       },
      +       {
      +          "description": "[dqbsr535] negatives (Rounded & Inexact)",
      +          "string": "-1.11111111111111111111111111111234551"
      +       },
      +       {
      +          "description": "[dqbsr533] negatives (Rounded & Inexact)",
      +          "string": "-1.11111111111111111111111111111234550"
      +       },
      +       {
      +          "description": "[dqbsr532] negatives (Rounded & Inexact)",
      +          "string": "-1.11111111111111111111111111111234549"
      +       },
      +       {
      +          "description": "[dqbsr432] check rounding modes heeded (Rounded & Inexact)",
      +          "string": "1.11111111111111111111111111111234549"
      +       },
      +       {
      +          "description": "[dqbsr433] check rounding modes heeded (Rounded & Inexact)",
      +          "string": "1.11111111111111111111111111111234550"
      +       },
      +       {
      +          "description": "[dqbsr435] check rounding modes heeded (Rounded & Inexact)",
      +          "string": "1.11111111111111111111111111111234551"
      +       },
      +       {
      +          "description": "[dqbsr434] check rounding modes heeded (Rounded & Inexact)",
      +          "string": "1.11111111111111111111111111111234650"
      +       },
      +       {
      +          "description": "[dqbas938] overflow results at different rounding modes (Overflow & Inexact & Rounded)",
      +          "string": "7e10000"
      +       },
      +       {
      +          "description": "Inexact rounding#1",
      +          "string": "100000000000000000000000000000000000000000000000000000000001"
      +       },
      +       {
      +          "description": "Inexact rounding#2",
      +          "string": "1E-6177"
              }
           ]
       }
      diff --git a/spec/spec_tests/data/corpus/decimal128-6.json b/spec/spec_tests/data/corpus/decimal128-6.json
      index 39d631c..eba6764 100644
      --- a/spec/spec_tests/data/corpus/decimal128-6.json
      +++ b/spec/spec_tests/data/corpus/decimal128-6.json
      @@ -75,6 +75,18 @@
                   "description": "Empty string",
                   "string": ""
               },
      +        {
      +            "description": "leading white space positive number",
      +            "string": " 1"
      +        },
      +        {
      +            "description": "leading white space negative number",
      +            "string": " -1"
      +        },
      +        {
      +            "description": "trailing white space",
      +            "string": "1 "
      +        },
               {
                   "description": "Invalid",
                   "string": "E"
      diff --git a/spec/spec_tests/data/corpus/decimal128-7.json b/spec/spec_tests/data/corpus/decimal128-7.json
      index 9a8d526..0b78f12 100644
      --- a/spec/spec_tests/data/corpus/decimal128-7.json
      +++ b/spec/spec_tests/data/corpus/decimal128-7.json
      @@ -267,6 +267,10 @@
                 "description": "[basx570] Near-specials (Conversion_syntax)",
                 "string": "9Inf"
              },
      +       {
      +          "description": "[basx512] The 'baddies' tests from DiagBigDecimal, plus some new ones (Conversion_syntax)",
      +          "string": "12 "
      +       },
              {
                 "description": "[basx517] The 'baddies' tests from DiagBigDecimal, plus some new ones (Conversion_syntax)",
                 "string": "12-"
      
      
      

            Assignee:
            jamis.buck@mongodb.com Jamis Buck
            Reporter:
            emily.stolfo Emily Stolfo
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: