Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-100957

Provide different QuerySettingsService implementations for router and shard

    • Type: Icon: Improvement Improvement
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Query Execution

      Currently the PQS module provides two different methods for the lookup on the router and shard. In order to make things simpler one could introduce a generic QuerySettingsService interface and provide two different implementations depending on the instance (via pimpl).

      The proposal would be to:

      • Provide such implementation, but do not adjust the callers with the new API, but instead delegate the implementation to the methods provided by the service instance (would require only query-settings team code review)
      • Adjust the callers with the new interface (the implementation is same, just interface change, therefore trivial review)

            Assignee:
            Unassigned Unassigned
            Reporter:
            denis.grebennicov@mongodb.com Denis Grebennicov
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: