While looking at sharding_ddl_util.h I noticed that there is a usage of an anonymous namespace in a header file, which is considered bad programming practice, because it doesn't actually make the code in that namespace invisible to other modules.