Build third_party libraries with NDEBUG defined in optimized non-debug builds

XMLWordPrintableJSON

    • Type: Task
    • Resolution: Done
    • Priority: Major - P3
    • 3.1.9
    • Affects Version/s: None
    • Component/s: Build
    • Fully Compatible
    • Build 7 08/10/15, Build 8 08/31/15, Build 9 (09/18/15), Build A (10/09/15)
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None

      We don't globally define NDEBUG in the tree because we use our own macros to detect optimization or debugging.

      Other libraries in third_party do reference NDEBUG in various ways, and expect it to be set correctly.

      In particular, the following libraries make some sort of reference to NDEBUG:

      • boost-1.56
      • gperftools-2.2
      • pcre-8.30
      • s2
      • snappy-1.1.2
      • v8

      We should enable NDEBUG for all of third party when appropriate. This most likely corresponds to the configuration where we are building with optimization on, and debugging off.

            Assignee:
            Jonathan Reams
            Reporter:
            Andrew Morrow (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: