ShardRegistry triggers clang 3.7's Wpessimizing-move warning

XMLWordPrintableJSON

    • Type: Bug
    • Resolution: Done
    • Priority: Major - P3
    • 3.1.9
    • Affects Version/s: None
    • Component/s: Internal Code, Sharding
    • None
    • Fully Compatible
    • ALL
    • QuInt A (10/12/15)
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None

      src/mongo/s/client/shard_registry.cpp:267:45: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
                  shardType.getName(), shardHost, std::move(_targeterFactory->create(shardHost)));
                                                  ^
      src/mongo/s/client/shard_registry.cpp:267:45: note: remove std::move call here
                  shardType.getName(), shardHost, std::move(_targeterFactory->create(shardHost)));
                                                  ^~~~~~~~~~                                   ~
      1 error generated.
      

            Assignee:
            Mathias Stearn
            Reporter:
            Mathias Stearn
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: