Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-28871

Remove write concern error backwards compatibility for user management commands

    • Minor Change
    • Dev Tools 2018-10-22, Dev Tools 2018-11-05, Security 2018-12-03, Security 2018-12-17
    • 0

      Generally speaking, when a command succeeds but fails waiting for write concern, the command response indicates ok:1, but has a writeConcernError field.

      When we made it so all commands that write can accept write concern, we finally standardized on that method of reporting write concern errors. User management commands, however, already supported write concern, and they reported errors differently - a failed write concern for them caused the whole command to report ok:0. In 3.4 we continued to provide that behavior for user management commands to preserve backwards compatibility until drivers were all updated to know to always check for the presence of the writeConcernError field. Now that it's been a full release since we made that change, we should be able to remove this bandaid and have user management commands handle write concern errors the same way as any other command.

      The bandaid code exists here, and already has a TODO to remove it.

            Assignee:
            spencer.jackson@mongodb.com Spencer Jackson
            Reporter:
            spencer@mongodb.com Spencer Brody (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved: