Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-30240

remove incorrect paragraph from getNextOpTime() comments in oplog.cpp

    • Type: Icon: Bug Bug
    • Resolution: Fixed
    • Priority: Icon: Trivial - P5 Trivial - P5
    • 3.5.11
    • Affects Version/s: None
    • Component/s: Replication
    • None
    • Fully Compatible
    • ALL

      The follow paragraph is no longer true and should be removed. We should link this ticket to the SERVER ticket in which this assumption changed.

      https://github.com/mongodb/mongo/blob/878e55a460de02de2f0171d3e9e1bcfc12bb80cc/src/mongo/db/repl/oplog.cpp#L148

      oplog.cpp
      /**
       * Allocates an optime for a new entry in the oplog, and updates the replication coordinator to
       * reflect that new optime.  Returns the new optime and the correct value of the "h" field for
       * the new oplog entry.
       *
       * NOTE: From the time this function returns to the time that the new oplog entry is written
       * to the storage system, all errors must be considered fatal.  This is because the this
       * function registers the new optime with the storage system and the replication coordinator,
       * and provides no facility to revert those registrations on rollback.
       */
      void getNextOpTime(OperationContext* opCtx,
                         Collection* oplog,
                         ReplicationCoordinator* replCoord,
                         ReplicationCoordinator::Mode replicationMode,
                         unsigned count,
                         OplogSlot* slotsOut) {
      

            Assignee:
            schwerin@mongodb.com Andy Schwerin
            Reporter:
            benety.goh@mongodb.com Benety Goh
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: