-
Type:
Task
-
Resolution: Won't Fix
-
Priority:
Minor - P4
-
None
-
Affects Version/s: None
-
Component/s: Testing Infrastructure
-
None
-
3
-
None
-
None
-
None
-
None
-
None
-
None
The disable_unit_tests conditional test in "run tests" is hard to follow as there is no indentation and the entire function is ignored if it's set to true.
Suggest changing the code block:
if [ ${disable_unit_tests|false} = "false" ]; then
# activate the virtualenv if it has been set up
${activate_virtualenv}
if [ -f /proc/self/coredump_filter ]; then
# Set the shell process (and its children processes) to dump ELF headers (bit 4),
...
fi # end if ${disable_unit_tests}
Should be refactored to
if [ ${disable_unit_tests|false} = "true" ]; then
exit 0
fi
# activate the virtualenv if it has been set up
${activate_virtualenv}
if [ -f /proc/self/coredump_filter ]; then
...