Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-43762

tighten the overload set for BSONObjBuilder::appendNumber

    • Type: Icon: Improvement Improvement
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 4.9.0
    • Affects Version/s: None
    • Component/s: Internal Code
    • Fully Compatible
    • Dev Tools 2019-11-04, Dev Tools 2019-12-02, Dev Tools 2019-12-16, Dev Tools 2019-12-30, Execution Team 2021-02-08, Execution Team 2021-02-22, Execution Team 2021-03-08, Execution Team 2021-03-22
    • 95

      In SERVER-9763 we improved the overload set for BSONObjBuilder::append.

      We still have the same trouble with BSONObjBuilder::appendNumber.
      Certain flags and compiler versions will complain about ambiguity, MacOS clang debug, argument is uint64_t, overload set is (int,double,size_t,long long). We probably need to get size_t out of the overload set.

      uint64_t should be size_t but isn't?

      This causes wasteful BFs:
      BF-14896
      BF-11187
      BF-5725

      and cleanup work:
      https://github.com/mongodb/mongo/commit/be20a34cf0af56cccc378861abb43e528daacea5

            Assignee:
            bynn.lee@mongodb.com Bynn Lee
            Reporter:
            billy.donahue@mongodb.com Billy Donahue
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved: