heap_profiler.cpp has a few bugs

XMLWordPrintableJSON

    • Server Programmability
    • ALL
    • 2
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None

      In file heap_profiler.cpp

      • member functions like size(), hash(), operator==, need const.
      • Consider replacing private HashTable implementation with standard one.
      • L479 bounds on j are infinite if numFrames < skipEndFrames. (This was fixed as a side-effect of SERVER-45357)
      • L486 first paren isn't necessarily start of function params.
        for example, "_Z1gIEPFviEv" demangles to "void (*g<>())(int)", a function returning a function pointer. Maybe just don't demangle.
      • L502 StringData receives a dangling reference.
        (This was fixed as a side-effect of SERVER-45357)
         
      • sortByActiveBytes comparator is not a stable order as the elements can shift position during the sort. Fix this comparator (SERVER-41787). 

       

       

       

       

            Assignee:
            Unassigned
            Reporter:
            Billy Donahue
            Votes:
            0 Vote for this issue
            Watchers:
            11 Start watching this issue

              Created:
              Updated: