@mathias.stearn pointed out on Slack that forcing the implicit dep on the ninja file is incorrect:
There are a few inaccuracies there. For one thing, ninja automatically makes command lines the equivalent of input edges so that if the command line changes, the target will be rebuilt (except for generator=1 targets, which should only be the build.ninja file itself). So we don't need to do anything special to make sure that things get rebuilt in that case. It also sorta-kinda makes everything that the build.ninja task depends on have an order-only edge on build.ninja implicitly (really, if the build.ninja needs to be updated, it will do that first and reparse (repeatedly) before scheduling anything that isn't on the path to regenerating build.ninja).
We forced this edge before we started using generator=1 which is why we needed it then but no longer do. Meson does not behave this way either.
- is depended on by
-
SERVER-47776 Promote ninja-next to stable
- Closed
- is duplicated by
-
SERVER-46748 The new native Ninja support doesn't register newly added files
- Closed