Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-48618

Remove TODO's for SERVER-48618

    • Type: Icon: Bug Bug
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 4.8.0
    • Affects Version/s: None
    • Component/s: None
    • Fully Compatible
    • ALL
    • Sharding 2020-07-27, Sharding 2020-08-10, Sharding 2020-08-24, Sharding 2020-09-21, Sharding 2020-10-05
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      new description

      We've decided not to do what this ticket originally aimed to do. Remove TODO's for this ticket in the codebase.

      old description
      Passing an empty NamespaceString to OperationShardingState::initializeClientRoutingVersionsFromCommand()   means the OperationShardingState cannot correctly store the shard/database version tied to the command.

      service_entry_point_common execCommandDatabase calls oss.initializeClientRoutingVersionsFromCommand(invocation->ns(), request.body).

      However, not all commands that go through this path are derived from InvocationBase - thus invocation->ns() yields an empty NamespaceString. 

      List of commands we found that pass an empty NamespaceString to OperationShardingState::initializeClientRoutingVersionsFromCommand() that aren't derived from InvocationBase:

      Additionally, DropConnectionsCmd derives from InvocationBase but passes an empty NamespaceString to OperationShardingState::initializeClientRoutingVersionsFromCommand().

       

            Assignee:
            haley.connelly@mongodb.com Haley Connelly
            Reporter:
            haley.connelly@mongodb.com Haley Connelly
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:
              None
              None
              None
              None