Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-50071

Change rollback common point checks in rollback_impl.cpp from invariants to fasserts

    • Type: Icon: Improvement Improvement
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • Replication
    • Repl 2020-10-19, Repl 2020-11-02

      In rollback_impl.cpp, we verify that the rollback common point is greater than both the replication commit point and the committed snapshot optime. We are currently using invariants to validate this. However, users may encounter situations where the common point will not be greater than the replication commit point and/or committed snapshot optime, and this invariant will fail. According to the wiki page on assertions, it may be better to use uasserts due to the possibility of users seeing this occur.

            Assignee:
            backlog-server-repl [DO NOT USE] Backlog - Replication Team
            Reporter:
            ali.mir@mongodb.com Ali Mir
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated: