Rename PrimaryOnlyService::Instance::onCompletion() to getCompletionFuture()

XMLWordPrintableJSON

    • Type: Task
    • Resolution: Fixed
    • Priority: Major - P3
    • 4.7.0
    • Affects Version/s: None
    • Component/s: None
    • None
    • Fully Compatible
    • Service arch 2020-09-07
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None

      It's a little confusing right now since Futures provide an onCompletion() method of their own to add completion callbacks, so you can wind up with instance->onCompletion().onCompletion([]{ /*[...]*/ });

       

      This also lets me sidestep a name collision with the existing TransactionCoordinator::onCompletion() method.

            Assignee:
            Spencer Brody (Inactive)
            Reporter:
            Spencer Brody (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: