Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-55279

Commit queue message validation got tricked by merging multiple commits

    • Type: Icon: Bug Bug
    • Resolution: Done
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: Testing Infrastructure
    • None
    • ALL
    • DAG 2021-07-26
    • 2

      In this patch I managed to commit a message without a SERVER ticket by accident: https://github.com/mongodb/mongo/commit/075e51fefecc54e219c56e75c3ba08c993b5c187

      It looks like it was because I batched multiple commits in one commit-queue merge:

      Commit queue patch has multiple commits (these will be tested together but merged separately). Continue? (y/n): y
       jstests/aggregation/sources/collStats/count.js     |  8 ++-
       .../sources/collStats/query_exec_stats.js          |  4 +-
       jstests/core/api_version_pipeline_stages.js        | 47 +++++++++++--
       src/mongo/db/commands/dbcommands.cpp               |  4 +-
       src/mongo/db/pipeline/SConscript                   |  7 +-
       .../db/pipeline/document_source_coll_stats.cpp     | 82 +++++++---------------
       src/mongo/db/pipeline/document_source_coll_stats.h | 30 +++++---
       .../db/pipeline/document_source_coll_stats.idl     | 69 ++++++++++++++++++
       .../document_source_parsing_validators.cpp         | 46 ++++++++++++
       .../pipeline/document_source_parsing_validators.h  | 38 ++++++++++
       .../db/pipeline/lite_parsed_document_source.h      | 13 ++++
       src/mongo/db/pipeline/lite_parsed_pipeline.cpp     |  4 ++
       .../common_mongod_process_interface.cpp            |  4 +-
       .../common_mongod_process_interface.h              |  2 +-
       .../process_interface/mongo_process_interface.h    |  3 +-
       .../process_interface/mongos_process_interface.h   |  2 +-
       .../stub_mongo_process_interface.h                 |  2 +-
       src/mongo/db/pipeline/storage_stats_spec.idl       | 50 +++++++++++++
       src/mongo/db/stats/SConscript                      |  3 +-
       src/mongo/db/stats/storage_stats.cpp               | 17 ++---
       src/mongo/db/stats/storage_stats.h                 |  5 +-
       21 files changed, 337 insertions(+), 103 deletions(-)
      5023694617 Add limited $collStats invocations to API Version 1
      7cc55db869 SERVER-54470 Use IDL to parse $collStats
      This is a summary of the patch to be submitted. Continue? (y/n): y
      

      That second-to-last line is the problem, and I think it validated the commit message as one big string: 'SERVER-54470 Use IDL to parse $collStats <- Add limited $collStats invocations to API Version 1'

            Assignee:
            jeff.zambory@mongodb.com Jeffrey Zambory
            Reporter:
            charlie.swanson@mongodb.com Charlie Swanson
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: