Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-57016

Consider changing MozJSScriptEngine to not log "kill" events for unrecognized OperationContexts

    • Type: Icon: Question Question
    • Resolution: Won't Do
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Query Execution

      At present, MozJSScriptEngine prints out a log message for every ServiceContext "kill" event, even when MozJSScriptEngine doesn't recognize the OperationContext of the request being killed (see MozJSScriptEngine::interrupt()).

      Given that MozJSScriptEngine registers as a listener when mongod starts up and it never unregisters, there is arguably little to no value in having MozJSScriptEngine print out log messages for "kill" events where it doesn't recognize the OperationContext.

      If we think there is some value in unconditionally logging every "kill" event, then this logging should happen in ServiceContext::killOperation() or in OperationContext::markKilled().

      The goal of this task is to decide between the following options:

      1. Leave things as-is.
      2. Change MozJSScriptEngine to only log "kill" events when it recognizes the OperationContext.
      3. Change MozJSScriptEngine to only log "kill" events when it recognizes the OperationContext, and update ServiceContext::killOperation() or OperationContext::markKilled() to log every "kill" event unconditionally.

      See HELP-24308 for context on how this issue came up.

            Assignee:
            backlog-query-execution [DO NOT USE] Backlog - Query Execution
            Reporter:
            andrew.paroski@mongodb.com Drew Paroski
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: