Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-60214

Make improvements in generic FCV commenting/terminology

    • Replication
    • Repl 2022-06-27, Repl 2022-07-11, Repl 2022-08-08, Repl 2022-08-22, Repl 2022-09-05, Repl 2022-09-19, Repl 2022-07-25, Repl 2023-05-01

      In the 5.0 release, we ran into occasional issues where generic FCV constants were used instead of real FCVs. For these cases, we should investigate any improvements to help engineers from accidentally stumbling into this error. We currently require any generic FCV usage to have a corresponding comment that begins with “(Generic FCV reference):”. One suggestion is to expand that comment to start with:

      (Generic FCV reference): This FCV reference must remain across binary version releases because…

       

      So that it is clear that this reference must persist across releases and that engineers must explain why the reference should persist across releases

      We could also consider renaming “generic” terminology to be more representative of their use cases, something to represent that these FCVs (kLatest, kLastLTS, etc) will change with each new release (i.e. in the 6.1 release kLatest points to kVersion_6_1 and kLastLTS points to kVersion_6_0, but in the 7.1 release kLatest points to kVersion_7_1 and kLastLTS points to kVersion_7_0)

            Assignee:
            backlog-server-repl [DO NOT USE] Backlog - Replication Team
            Reporter:
            xuerui.fa@mongodb.com Xuerui Fa
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: