Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-63554

BackupBlock filepaths and filenames improperly mixed

    • Type: Icon: Bug Bug
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 8.1.0-rc0
    • Affects Version/s: None
    • Component/s: Portability
    • Storage Execution
    • Fully Compatible
    • ALL
    • Execution Team 2024-07-08, Execution Team 2024-07-22, Execution Team 2024-08-05, Execution Team 2024-08-19
    • 200

      1. BackupCursor Unit Tests use BackupBlock interface improperly (functional)

      Some unit tests in the enterprise repo improperly pass in a filename stem instead of a filepath to the BackupBlock() constructor. Much of this code is brittle. Some examples:

      • TestTypicalCursorLifetime (backup_cursor_service_test.cpp)
      • TestFilenameCheck (document_source_backup_cursor_test.cpp)

       

      2. _forTest & _ForTest naming is inconsistent (style)

      standardize on _forTest which is more prevalent

      src/fcbis/file_copy_based_initial_syncer.h

      src/fcbis/file_copy_based_initial_syncer_test.cpp

      • getBackupCursorFiles_ForTest
      • getExtendedBackupCursorFiles_ForTest
      • setOldStorageFilesToBeDeleted_ForTest
        • corollary: getOldStorageFilesToBeDeleted_forTest

       

            Assignee:
            malik.endsley@mongodb.com Malik Endsley
            Reporter:
            matt.kneiser@mongodb.com Matt Kneiser
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: